[Tests] Share modal redesign refactor FTRs #179694
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rshen91
changed the title
|
/ci |
|
/ci |
3 tasks
… into share-modal-redesign-tests-ftrs
|
/ci |
rshen91
added
the
Team:SharedUX
|
/ci |
|
/ci |
|
/ci |
💔 Build FailedFailed CI Steps
Test Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @rshen91 |
5 tasks
|
Changed a lot will open a new PR |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is built off the branch #179206 with the most recent changes for the share modal redesign. The kibana.yml is set to
share.new_version.enabled: trueto reflect the new share modal redesign changes and the tests that need to be removed or refactored for the share redesign to be merged into main.One of the largest changes in the redesign is that there is no radio button in the links share component. The link will be saved object for Lens and discover and dashboard's link that is copied is the snapshot url.
For share links…
Remove ‘short URL’ option
Remove the radio selection for saved object vs snapshot (for: dash, lens, and discover)
When user clicks the ‘copy link’ button
For dashboard: copy the “snapshot” URL to user clipboard
For lens: copy the “saved object” URL to user clipboard.
If lens is not saved to library you cannot copy (show unsaved changed error as in figma)
For discover: discover is saved: copy the “snapshot” URL to user clipboard
Default to short URL
Copy POST URL
Shown in cases where it is shown today
If unsaved changes, show alternative tooltip text (see figma)
reference: https://docs.google.com/document/d/1wiY9c1LY0gk_h_k-v8C8XZcoMLuvqbnKQlrqbSYzdbk/edit?usp=sharing